Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for CGC w/ Automation #8

Merged
merged 17 commits into from
Sep 14, 2021
Merged

Adding support for CGC w/ Automation #8

merged 17 commits into from
Sep 14, 2021

Conversation

jordan-rash
Copy link
Contributor

@jordan-rash jordan-rash commented Aug 25, 2021

Copy link
Collaborator

@adthrasher adthrasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the IBC files:
IBC_CCDI/TCGABRCA_log2fpkm.SIG.txt
IBC_CCDI/GEP.195.quantileNormalized.geneLevel_log2.eset
IBC_CCDI/TCGABRCA_log2fpkm.TF.txt

@adamdingliang - Someone from your team will need to draft a description for the tool in CGC. See this example: https://cgc.sbgenomics.com/public/apps#ZCHONG/novobreak-commit/novobreak-analysis/. It would also be best to have helpful documentation for each of the input to the script (expression set, transcription factor network, signaling network, and metadata file). This should include information about the file formats and how to generate them. Ideally, it would also link to examples.

Dockerfile.cgc Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
cgc/netbid.cwl Outdated Show resolved Hide resolved
cgc/netbid.cwl Outdated Show resolved Hide resolved
@adamdingliang
Copy link
Contributor

We can remove the IBC files:
IBC_CCDI/TCGABRCA_log2fpkm.SIG.txt
IBC_CCDI/GEP.195.quantileNormalized.geneLevel_log2.eset
IBC_CCDI/TCGABRCA_log2fpkm.TF.txt

@adamdingliang - Someone from your team will need to draft a description for the tool in CGC. See this example: https://cgc.sbgenomics.com/public/apps#ZCHONG/novobreak-commit/novobreak-analysis/. It would also be best to have helpful documentation for each of the input to the script (expression set, transcription factor network, signaling network, and metadata file). This should include information about the file formats and how to generate them. Ideally, it would also link to examples.

Hi @adthrasher , I will work on the description. Thanks.

@jordan-rash
Copy link
Contributor Author

We can remove the IBC files:
IBC_CCDI/TCGABRCA_log2fpkm.SIG.txt
IBC_CCDI/GEP.195.quantileNormalized.geneLevel_log2.eset
IBC_CCDI/TCGABRCA_log2fpkm.TF.txt

Done

cgc/netbid.cwl Outdated Show resolved Hide resolved
cgc/netbid.cwl Outdated Show resolved Hide resolved
cgc/netbid.cwl Outdated Show resolved Hide resolved
cgc/netbid.cwl Outdated Show resolved Hide resolved
cgc/netbid.cwl Outdated Show resolved Hide resolved
cgc/netbid.cwl Outdated Show resolved Hide resolved
@jordan-rash
Copy link
Contributor Author

@adthrasher I just rebased and squashed the commits while dropping the GH change.....I am reviewing now, but another set of eyes is helpful....when I use the "Commit Changes" button in the UI, the commit log is not helpful, so I might have missed a piece

Copy link
Collaborator

@adthrasher adthrasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the small change to the environment secrets, then it looks good.

@adthrasher adthrasher changed the title [DO NOT MERGE] Adding support for CGC w/ Automation Adding support for CGC w/ Automation Sep 13, 2021
@adthrasher adthrasher marked this pull request as ready for review September 13, 2021 18:54
Copy link
Contributor

@adamdingliang adamdingliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed sanity check

@adthrasher adthrasher merged commit 38fa69b into jyyulab:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants