-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for CGC w/ Automation #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the IBC files:
IBC_CCDI/TCGABRCA_log2fpkm.SIG.txt
IBC_CCDI/GEP.195.quantileNormalized.geneLevel_log2.eset
IBC_CCDI/TCGABRCA_log2fpkm.TF.txt
@adamdingliang - Someone from your team will need to draft a description for the tool in CGC. See this example: https://cgc.sbgenomics.com/public/apps#ZCHONG/novobreak-commit/novobreak-analysis/. It would also be best to have helpful documentation for each of the input to the script (expression set, transcription factor network, signaling network, and metadata file). This should include information about the file formats and how to generate them. Ideally, it would also link to examples.
Hi @adthrasher , I will work on the description. Thanks. |
Co-authored-by: Andrew Thrasher <[email protected]>
Done |
PR feedback from @adthrasher
@adthrasher I just rebased and squashed the commits while dropping the GH change.....I am reviewing now, but another set of eyes is helpful....when I use the "Commit Changes" button in the UI, the commit log is not helpful, so I might have missed a piece |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the small change to the environment secrets, then it looks good.
Co-authored-by: Andrew Thrasher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed sanity check
CC: @adthrasher