Enable building Onigmo in WebAssembly for Opal-compatible regular expressions #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 82.86% 82.79% -0.08%
==========================================
Files 63 63
Lines 12613 12646 +33
==========================================
+ Hits 10452 10470 +18
- Misses 2161 2176 +15
Continue to review full report at Codecov.
|
scodeman
reviewed
Mar 30, 2021
| # Download WASI-SDK from: | ||
| # https://github.com/WebAssembly/wasi-sdk/releases | ||
|
|
||
| if [ $BUILD == 'wasi' ]; then |
There was a problem hiding this comment.
Suggested change
| if [ $BUILD == 'wasi' ]; then | |
| if [ "$BUILD" == 'wasi' ]; then |
to avoid the error build-wasm.sh: line 4: [: ==: unary operator expected when $BUILD is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables building Onigmo in WebAssembly via WASI.
The changes it proposes are minimal and only specific to the WebAssembly build. This work is being used inside the
opal-webassemblygem to enable regular expression compatibility in the browser and Opal-compiled Ruby. This was originally developed to allow Interscript rules to be run in the browser.This is a contribution from Ribose Inc. Special thanks to @webdev778 for the great work.