Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor with Generics #20

Merged
merged 6 commits into from
Mar 16, 2022
Merged

Refactor with Generics #20

merged 6 commits into from
Mar 16, 2022

Conversation

k-yomo
Copy link
Owner

@k-yomo k-yomo commented Feb 17, 2022

  • Refactored with generics
  • Upgrade library version to v2

@k-yomo k-yomo force-pushed the generics branch 5 times, most recently from bd072ec to d1071c3 Compare February 17, 2022 13:02
@k-yomo k-yomo changed the title Generics Refactor with Generics Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #20 (f4ae08e) into master (6c39372) will increase coverage by 10.18%.
The diff coverage is 80.64%.

@@             Coverage Diff             @@
##           master      #20       +/-   ##
===========================================
+ Coverage   78.94%   89.13%   +10.18%     
===========================================
  Files           4        3        -1     
  Lines         190       92       -98     
===========================================
- Hits          150       82       -68     
+ Misses         27        8       -19     
+ Partials       13        2       -11     
Impacted Files Coverage Δ
example/article.go 100.00% <ø> (ø)
factory.go 90.47% <80.00%> (-9.53%) ⬇️
reflectutil.go 73.33% <100.00%> (-26.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c39372...f4ae08e. Read the comment docs.

@k-yomo k-yomo force-pushed the generics branch 3 times, most recently from eb09fa6 to 85ccc49 Compare February 17, 2022 13:11
@k-yomo k-yomo merged commit c59a981 into master Mar 16, 2022
@k-yomo k-yomo deleted the generics branch March 16, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant