Use atomic.Bool instead of atomic.Value for leader status

Lease pool's leader status field was an atomic.Value that is always used
for booleans only. This requires pre-initializing it through
Store(false) and also typecasting when retrieving.

By using atomic.Bool, the zero value is false and the value type is
always bool.

Signed-off-by: Kimmo Lehto <[email protected]>

pkg/component/controller/leaderelector/leasepool.go

@@ -32,27 +32,26 @@ type LeasePool struct {
 
 	invocationID      string
 	stopCh            chan struct{}
-	leaderStatus      atomic.Value
+	leaderStatus      atomic.Bool
 	kubeClientFactory kubeutil.ClientFactoryInterface
 	leaseCancel       context.CancelFunc
 
 	acquiredLeaseCallbacks []func()
 	lostLeaseCallbacks     []func()
 }
 
-var _ Interface = (*LeasePool)(nil)
-var _ manager.Component = (*LeasePool)(nil)
+var (
+	_ Interface         = (*LeasePool)(nil)
+	_ manager.Component = (*LeasePool)(nil)
+)
 
 // NewLeasePool creates a new leader elector using a Kubernetes lease pool.
 func NewLeasePool(invocationID string, kubeClientFactory kubeutil.ClientFactoryInterface) *LeasePool {
-	d := atomic.Value{}
-	d.Store(false)
 	return &LeasePool{
 		invocationID:      invocationID,
 		stopCh:            make(chan struct{}),
 		kubeClientFactory: kubeClientFactory,
 		log:               logrus.WithFields(logrus.Fields{"component": "poolleaderelector"}),
-		leaderStatus:      d,
 	}
 }
 
@@ -118,5 +117,5 @@ func (l *LeasePool) Stop() error {
 }
 
 func (l *LeasePool) IsLeader() bool {
-	return l.leaderStatus.Load().(bool)
+	return l.leaderStatus.Load()
 }