Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marshal containerd.toml instead of templating it #4575

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 10, 2024

Description

This allows for proper escaping of values and removes the need to do it manually for the imported path values. Also, use simple maps instead of custom structs to construct the config. This is a bit simpler and more straightforward.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

This allows for proper escaping of values and removes the need to do it
manually for the imported path values. Also, use simple maps instead of
custom structs to construct the config. This is a bit simpler and more
straightforward.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 marked this pull request as ready for review June 10, 2024 16:01
@twz123 twz123 requested a review from a team as a code owner June 10, 2024 16:01
@twz123 twz123 requested review from ncopa and makhov June 10, 2024 16:01
@twz123 twz123 merged commit 50fb76c into k0sproject:main Jun 11, 2024
81 checks passed
@twz123 twz123 deleted the marshal-containerd-toml branch June 11, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants