Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstall already installed k0s to reconfigure installFlags #756

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

kke
Copy link
Contributor

@kke kke commented Aug 23, 2024

Fixes #302

If k0s is already installed, use k0s install --force to reinstall it if installFlags have changed.

Also, reinstall will now be performed during upgrades.

Note that changing the flags on an existing cluster may cause problems.

@kke kke added the enhancement New feature or request label Aug 23, 2024
@kke
Copy link
Contributor Author

kke commented Aug 26, 2024

Not yet completely convinced the re-install blindly strategy is a winner. Maybe comparing the flags in ExecStart (or openrc -equivalent) would be better.

@kke
Copy link
Contributor Author

kke commented Aug 28, 2024

k0s status has Args:.. 🤔

// k0s status -o json
{
   "Version": "v1.30.4+k0s.0",
   "Pid": 192,
   "PPid": 0,
   "Role": "controller",
   "SysInit": "",
   "StubFile": "",
   "Output": "",
   "Workloads": false,
   "SingleNode": false,
   "Args": [
      "/root/k0s-v1.30.4+k0s.0-amd64",
      "controller",
      "--enable-dynamic-config=true"
   ],

@kke
Copy link
Contributor Author

kke commented Aug 28, 2024

New approach: check for changes in installFlags vs status.Args reported by k0s status.

@kke kke force-pushed the installflags branch 2 times, most recently from de03a89 to 96b59d5 Compare August 28, 2024 10:39
@kke kke marked this pull request as ready for review September 3, 2024 12:15
@ry4nz
Copy link

ry4nz commented Sep 6, 2024

@kke Do you known what's the timeline for this to be merged and released?

@kke
Copy link
Contributor Author

kke commented Sep 8, 2024

@kke Do you known what's the timeline for this to be merged and released?

Would be great if someone tried it out. I can of course put it in a beta if that makes it easier.

@kke kke merged commit cc82677 into main Sep 9, 2024
41 checks passed
@kke kke deleted the installflags branch September 9, 2024 07:47
@kke
Copy link
Contributor Author

kke commented Sep 9, 2024

@tppolkow
Copy link

tppolkow commented Sep 9, 2024

I've verified via v0.19.0-beta.1 I am able to update install flags with a second k0sctl apply and it works as expected. Thanks for the fix @kke !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying the installFlags doesn't do anything after initial install
3 participants