re-pull-request allow tokens and hotwords be loaded from buffered string driectly #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther than from external files) currently, only supported OnlineTransducer models
… test streaming models loading tokens and hotworks from buffered strings directly
Co-authored-by: Fangjun Kuang <[email protected]>
Co-authored-by: Fangjun Kuang <[email protected]>
2. rewrite some code to make it more readable 3. updated the c-api-examples/streaming-zipformer-buffered-tokens-hotwords-c-api.c
… hotwords are read from files before being filled into buffers 2. updated the test yaml
csukuangfj
reviewed
Sep 12, 2024
c-api-examples/streaming-zipformer-buffered-tokens-hotwords-c-api.c
Outdated
Show resolved
Hide resolved
c-api-examples/streaming-zipformer-buffered-tokens-hotwords-c-api.c
Outdated
Show resolved
Hide resolved
c-api-examples/streaming-zipformer-buffered-tokens-hotwords-c-api.c
Outdated
Show resolved
Hide resolved
csukuangfj
reviewed
Sep 12, 2024
…api.c Co-authored-by: Fangjun Kuang <[email protected]>
…api.c Co-authored-by: Fangjun Kuang <[email protected]>
Co-authored-by: Fangjun Kuang <[email protected]>
…api.c Co-authored-by: Fangjun Kuang <[email protected]>
Co-authored-by: Fangjun Kuang <[email protected]>
Co-authored-by: Fangjun Kuang <[email protected]>
Co-authored-by: Fangjun Kuang <[email protected]>
Co-authored-by: Fangjun Kuang <[email protected]>
Co-authored-by: Fangjun Kuang <[email protected]>
|
Thanks for your suggestions, I have learned a lot from such a great open source project |
1. tokens and hotwords buffers are freed once the recognizier creation is called 2. used ReadFile instead of read_file 3. fixed some other minor suggestions
Co-authored-by: Fangjun Kuang <[email protected]>
|
please leave a message when you think it is ready for merge. |
it is ready to merge, modifications on paraformers and ctc models are coming in the next commits |
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the code by the previous suggestions,
formatted the code with clang-format to avoid style-check failure