Add support for docker registry secret #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
requested changes
Jun 26, 2023
pkg/apis/helm.cattle.io/v1/types.go
Outdated
| @@ -37,6 +37,7 @@ type HelmChartSpec struct { | |||
| AuthSecret *corev1.LocalObjectReference `json:"authSecret,omitempty"` | |||
|
|
|||
| AuthPassCredentials bool `json:"authPassCredentials,omitempty"` | |||
| DockerRegistrySecret *corev1.LocalObjectReference `json:"dockerRegistrySecret,omitempty"` | |||
There was a problem hiding this comment.
please make sure that all the files are formatted using go fmt. Most editors do this for you but the indentation here appears to be off.
There was a problem hiding this comment.
Should be fixed now
|
LGTM, but please sign-off your commits for DCO. |
This allows OCI registries to inherit configuration from the configured docker-registry secret Signed-off-by: Shaun Becker <[email protected]>
smbecker
force-pushed
the
sb-docker-registry
branch
from
8ec412c
to
cea5af0
Compare
I had to look up what that even meant 😆. It should be good now. |
brandond
approved these changes
Jun 28, 2023
|
@brandond, do you have any estimate when this will make it into a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows OCI registries to inherit configuration from the configured docker-registry secret
Linked Issues