Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing kernel config check #10100

Merged
merged 1 commit into from
May 24, 2024
Merged

Add missing kernel config check #10100

merged 1 commit into from
May 24, 2024

Conversation

zouxianyu
Copy link
Contributor

@zouxianyu zouxianyu commented May 15, 2024

Added a check for the kernel config CONFIG_IP_NF_TARGET_REJECT, as this is required to run k3s.

Proposed Changes

When I used TOPEET's rk3588 board, I found that k3s was not working with the official image. l found out that the kernel needs to enable CONFIG_IP_NF_TARGET_REJECT but check-config.sh doesn't check that.

Types of Changes

I added a config check for CONFIG_IP_NF_TARGET_REJECT to the check-config.sh script.

Verification

Here are some error messages taken from journalctl -u k3s.

master k3s[2242]: E0515 06:41:43.060036    2242 proxier.go:1525] "Failed to execute iptables-restore" err=<
master k3s[2242]:         exit status 2: iptables-restore v1.8.7 (legacy): Couldn't load target `REJECT':No such file or directory
master k3s[2242]:
master k3s[2242]:         Error occurred at line: 9
master k3s[2242]:         Try `iptables-restore -h' or 'iptables-restore --help' for more information.
master k3s[2242]:  >

Testing

With CONFIG_IP_NF_TARGET_REJECT enabled in the kernel, k3s works fine.

Linked Issues

#10099

User-Facing Change

Further Comments

@zouxianyu zouxianyu requested a review from a team as a code owner May 15, 2024 07:36
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.61%. Comparing base (dba30ab) to head (9cdd206).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10100      +/-   ##
==========================================
- Coverage   46.55%   41.61%   -4.94%     
==========================================
  Files         173      173              
  Lines       14645    14645              
==========================================
- Hits         6818     6095     -723     
- Misses       6540     7386     +846     
+ Partials     1287     1164     -123     
Flag Coverage Δ
e2etests 36.37% <ø> (-10.01%) ⬇️
inttests 19.80% <ø> (?)
unittests 11.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants