Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CoreDNS to version 1.8.3. #3168

Merged
merged 6 commits into from
Apr 9, 2021
Merged

Conversation

briandowns
Copy link
Contributor

@briandowns briandowns commented Apr 8, 2021

This also required a run of go generate.

Proposed Changes

Types of Changes

Updates CoreDNS to 1.8.3.

Verification

Linked Issues

#3001

Further Comments

@briandowns briandowns requested a review from a team as a code owner April 8, 2021 22:54
@briandowns briandowns self-assigned this Apr 8, 2021
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
@brandond
Copy link
Member

brandond commented Apr 9, 2021

It looks like the CoreDNS RBAC needs to be updated:

[[36mPARALLEL[m] E0409 20:45:48.534248       1 reflector.go:138] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:167: Failed to watch *v1beta1.EndpointSlice: failed to list *v1beta1.EndpointSlice: endpointslices.discovery.k8s.io is forbidden: User “system:serviceaccount:kube-system:coredns” cannot list resource “endpointslices” in API group “discovery.k8s.io” at the cluster scope
[[36mPARALLEL[m] E0409 20:46:38.910482       1 reflector.go:138] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:167: Failed to watch *v1beta1.EndpointSlice: failed to list *v1beta1.EndpointSlice: endpointslices.discovery.k8s.io is forbidden: User “system:serviceaccount:kube-system:coredns” cannot list resource “endpointslices” in API group “discovery.k8s.io” at the cluster scope

We should compare the current RBAC to the manifest here: https://github.com/coredns/deployment/blob/f15e936388424b64c927b1d8f6965575ea592ea8/kubernetes/coredns.yaml.sed#L6-L30

Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
@brandond brandond self-requested a review April 9, 2021 23:18
@briandowns briandowns merged commit 693c529 into k3s-io:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants