Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.27] Network defaults are duplicated, remove one #8551

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

manuelbuil
Copy link
Contributor

Backport: #8523
Issue: #8548

@manuelbuil manuelbuil requested a review from a team as a code owner October 4, 2023 06:26
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9a930c6) 47.22% compared to head (9c70ee4) 51.70%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27    #8551      +/-   ##
================================================
+ Coverage         47.22%   51.70%   +4.47%     
================================================
  Files               144      144              
  Lines             14622    14611      -11     
================================================
+ Hits               6905     7554     +649     
+ Misses             6628     5876     -752     
- Partials           1089     1181      +92     
Flag Coverage Δ
e2etests 49.12% <ø> (?)
inttests 44.65% <ø> (+0.12%) ⬆️
unittests 19.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/daemons/control/server.go 75.58% <ø> (+3.50%) ⬆️

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelbuil manuelbuil merged commit e7e7615 into k3s-io:release-1.27 Oct 5, 2023
15 checks passed
@manuelbuil manuelbuil deleted the netCleanUp127 branch October 5, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants