-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump spegel to v0.0.20-k3s1 #9863
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9863 +/- ##
==========================================
- Coverage 52.87% 46.67% -6.20%
==========================================
Files 157 157
Lines 13822 13822
==========================================
- Hits 7308 6452 -856
- Misses 5128 6132 +1004
+ Partials 1386 1238 -148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We might have to revert this one: k3s-io/spegel@8a5978f I don't agree with his approach to fixing the error handling. With his fix, if there is an error it just stops syncing images until the next time k3s is restarted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit on dropped patches
Okay I can work on a patch bringing that back and put out a |
yeah, probably just revert + cherry-pick should do it. |
Now there's another one! https://github.com/spegel-org/spegel/releases/tag/v0.0.20 |
Welp, looks like its a high severity CVE on quic-go |
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Pinned version is now out of date, indirect dependencies are now newer, with CVE issue fixed Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola [email protected]
Proposed Changes
so we are down from 5 patches to 3 patchesBut we added more 🙃 .quic-go
pins. The indirect version is now v0.42.0 (because we bumped libp2p), which resolves the CVE we originally pinned avoid.Types of Changes
Dependency Bump
Verification
CI Green
Testing
Linked Issues
#7151
User-Facing Change
Further Comments