Handle Interface already exists due to SetNetworkStatus failed #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longchuanzheng
force-pushed
the
handleSetNetworkStatusFailed
branch
2 times, most recently
from
5a6342c
to
f6a5223
Compare
Signed-off-by: zhuanlan <[email protected]>
Longchuanzheng
force-pushed
the
handleSetNetworkStatusFailed
branch
from
f6a5223
to
435fa68
Compare
|
I don't think this is the final solution, just hope it can spark discussion. |
|
Or we can delete all attachments in this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pr create a DEL request when controller find a ADD request return "interface alreadt exists". This will undo any effects of SetNetworkStatus failure.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #235
Special notes for your reviewer (optional):