Use GlobalMgr for SriovNetwork controllers #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using 2 managers for the same controllers causes inconsistency in objects reconcilation. For example we saw a problem with some SriovNetwork update events not reaching the controller (Reconcile was not triggered). Using the same Mgr as the specified client for the controller solves these kind of problems. Signed-off-by: Ori Braunshtein <[email protected]>
oribon
changed the title
|
lgtm waiting for other maintainers to approve |
|
@oribon |
|
This error was introduced by https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/bc40302df612fc62e0252977011fe7f95abe02b0/main.go The |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using 2 managers for the same controllers causes inconsistency in
objects reconcilation. For example we saw a problem with some SriovNetwork
update events not reaching the controller (Reconcile was not triggered).
Using the same Mgr as the specified client for the controller solves these kind of problems.
Signed-off-by: Ori Braunshtein [email protected]