-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VFs configuration for InfiniBand NICs #275
Conversation
Thanks for your PR,
To skip the vendors CIs use one of:
|
pkg/utils/utils.go
Outdated
if strings.EqualFold(iface.LinkType, "IB") { | ||
// LinkType is an optional field. Let's fallback to current link type | ||
// if nothing is specified in the SriovNodePolicy | ||
linkType := ifaceStatus.LinkType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here you want to put the sriov policy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the pointing me on it. will fix this typo asap.
Thanks for your PR,
To skip the vendors CIs use one of:
|
Go / test (pull_request) failure is not related to this change |
@pliurh @zshi-redhat could you please run e2e ci? |
Thanks for your PR,
To skip the vendors CIs use one of:
|
/lgtm |
looks like there is a problem with the controller-gen |
Is seems to be a golang issue witch is fixed in pr #277 |
/test-all |
1 similar comment
/test-all |
Thanks for your PR,
To skip the vendors CIs use one of:
|
Closes: #274