Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gosimple issues #290

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

rollandf
Copy link
Contributor

This commit fixes issues found with:
golangci-lint run --disable-all -E gosimple

Signed-off-by: Fred Rolland [email protected]

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@rollandf
Copy link
Contributor Author

See issue #288

@adrianchiris
Copy link
Collaborator

@rollandf mind rebasing this PR ?

This commit fixes issues found with:
`golangci-lint run --disable-all -E gosimple`

Signed-off-by: Fred Rolland <[email protected]>
@github-actions
Copy link

github-actions bot commented May 8, 2022

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@rollandf
Copy link
Contributor Author

rollandf commented May 8, 2022

@rollandf mind rebasing this PR ?

Done

@SchSeba SchSeba merged commit 9a71b6e into k8snetworkplumbingwg:master May 17, 2022
@rollandf rollandf deleted the gosimple branch June 6, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants