Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for writer response on Refresh #333

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Wait for writer response on Refresh #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/daemon/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,8 @@ func (dn *Daemon) nodeStateSyncHandler(generation int64) error {
syncStatus: "Succeeded",
lastSyncError: "",
}
// wait for writer to refresh the status
<-dn.syncCh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC as SyncCh is initialized with a zero capacity. then [1] will block until someone is trying to read from the channel.

nice catch here @rollandf

[1]

sriov-network-operator/pkg/daemon/writer.go

Line 98 in 815fd13

syncCh <- struct{}{}

}

return nil
Expand Down