improve drain check #354
Merged
improve drain check #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
/cc @zeeke @e0ne @adrianchiris |
Pull Request Test Coverage Report for Build 3059567663
💛 - Coveralls |
|
I think there is a regression in case the I arranged a unit test with information taken from a test cluster here: It works without changes at generic_plugin.go:166. Can you please add the test to the PR? |
SchSeba
force-pushed
the
improve_drain_check
branch
from
1ed6dba
to
adf181f
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
force-pushed
the
improve_drain_check
branch
from
adf181f
to
d440259
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
force-pushed
the
improve_drain_check
branch
from
d440259
to
664f718
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
LGTM |
adrianchiris
reviewed
Sep 7, 2022
| @@ -163,8 +163,8 @@ func needDrainNode(desired sriovnetworkv1.Interfaces, current sriovnetworkv1.Int | |||
| needDrain = true | |||
| return | |||
| } | |||
| if iface.Mtu != 0 && iface.Mtu != ifaceStatus.Mtu { | |||
| glog.V(2).Infof("generic-plugin needDrainNode(): need drain, expect MTU %v, current MTU %v", iface.Mtu, ifaceStatus.Mtu) | |||
| if utils.NeedUpdate(&iface, &ifaceStatus) { | |||
There was a problem hiding this comment.
this method checks also num VFs so you can remove the condition at L161
adrianchiris
reviewed
Sep 7, 2022
| sriovnetworkv1 "github.com/k8snetworkplumbingwg/sriov-network-operator/api/v1" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Any chance to use ginkgo and gomega as we do in other places ?
also you could define a test package (i.e generic_test) and just test the interface calls WDYT ?
SchSeba
force-pushed
the
improve_drain_check
branch
from
664f718
to
a2140df
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Hi @adrianchiris please take a look when you have time |
SchSeba
force-pushed
the
improve_drain_check
branch
from
a2140df
to
c1c13de
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
|
||
| }) | ||
|
|
||
| //func TestNeedDrainNode_InterfaceWithBadMtuShouldDrainTheNode(t *testing.T) { |
There was a problem hiding this comment.
miss that :P
Thanks!
adrianchiris
approved these changes
Sep 14, 2022
We need to check in the drain function also if VFs exist If they exist we need to check if any other configuration is required (link driver and MTU) If a change to the VF is requested we should drain the node because we can have pods using the VF Signed-off-by: Sebastian Sch <[email protected]>
SchSeba
force-pushed
the
improve_drain_check
branch
from
c1c13de
to
6cdb482
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
adrianchiris
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to check in the drain function also if VFs exist
If they exist we need to check if any other configuration is required (link driver and MTU)
If a change to the VF is requested we should drain the node because we can have pods using the VF
Signed-off-by: Sebastian Sch [email protected]