Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NVIDIA ConnectX-7 to supported NICs #360

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Add NVIDIA ConnectX-7 to supported NICs #360

merged 1 commit into from
Oct 10, 2022

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Sep 12, 2022 •
edited
Loading

Closes #362

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Sep 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3051139206

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 23.716%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 67.33%
Totals Coverage Status
Change from base Build 3042933490: -0.03%
Covered Lines: 1754
Relevant Lines: 7396
💛 - Coveralls

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@e0ne
Copy link
Collaborator Author

e0ne commented Sep 14, 2022

/test-all

adrianchiris
adrianchiris reviewed Sep 15, 2022
View reviewed changes
deployment/sriov-network-operator/templates/configmap.yaml
@@ -20,6 +20,7 @@ data:
Nvidia_mlx5_ConnectX-6: "15b3 101b 101c"
Nvidia_mlx5_ConnectX-6_Dx: "15b3 101d 101e"
Nvidia_mlx5_ConnectX-6_Lx: "15b3 101f 101e"
Nvidia_mlx5_ConnectX-7: "15b3 1021 101e"
Copy link
Collaborator

@adrianchiris adrianchiris Sep 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this is not a typo, VF id (101e) remains the same

@wizhaoredhat
Copy link
Contributor

Isn't there supposed to be an issue attached to this PR. As per the rules here: https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/master/doc/supported-hardware.md#initial-support

@e0ne
Copy link
Collaborator Author

e0ne commented Sep 16, 2022

Isn't there supposed to be an issue attached to this PR. As per the rules here: https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/master/doc/supported-hardware.md#initial-support

Thanks for the review, @wizhaoredhat. Updated PR description with ticket link

@wizhaoredhat
Copy link
Contributor

/lgtm

SchSeba
SchSeba approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Eoghan1232
Copy link
Collaborator

2 approvals already received for this PR.
Merging now.

@Eoghan1232 Eoghan1232 merged commit f402cd3 into k8snetworkplumbingwg:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@SchSeba SchSeba SchSeba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding support for NVIDIA ConnectX-7
6 participants
@e0ne @coveralls @wizhaoredhat @Eoghan1232 @SchSeba @adrianchiris