Fix machine config update in sriovnetworkpoolconfig_controller #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Investigating that foundMC.Spec.Config.Raw is never equal to mc.Spec.Config.Raw. Even though there are no changes to the machine config files. It is most likely metadata. Posting this PR (in draft state) such that developers with experience with the Machine Config API can take a look. EDIT: Found the issue was that the Raw JSON would rearrange some fields. We have to unmarshal the JSON and then compare. |
Merged
Pull Request Test Coverage Report for Build 3577759018
💛 - Coveralls |
zshi-redhat
reviewed
Nov 29, 2022
These fixes only apply to Openshift clusters with the machine config operator. The controller was not detecting changes to the machine config files. Firstly if the existing MachineConfig's ignition JSON differs from the rendered MachineConfig's ignition JSON then we should update the MachineConfig. Then we should update the MachineConfig with the rendered MachineConfig. This logic had an incorrect implementation priorly.
wizhaoredhat
force-pushed
the
fix_machine_config_updating
branch
from
1b85bb9
to
45257c4
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
wizhaoredhat
changed the title
bn222
reviewed
Nov 30, 2022
|
/cc @SchSeba |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes only apply to Openshift clusters with the machine config operator.
The controller was not detecting changes to the machine config files. Firstly if the existing MachineConfig's ignition JSON differs from the rendered MachineConfig's ignition JSON then we should update the MachineConfig. Then we should update the MachineConfig with the rendered MachineConfig. This logic had an incorrect implementation priorly.