Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm] Dont force deployment on control nodes #444

Conversation

adrianchiris
Copy link
Collaborator

use preferred scheduling instead.

This is desired for a better user experience
on managed k8s clusters where control plane nodes
are not part of the cluster

use preferred scheduling instead.

This is desired for a better user experience
on managed k8s clusters where control plane nodes
are not part of the cluster

Signed-off-by: adrianc <[email protected]>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5055011305

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 25.606%

Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 66.04%
Totals Coverage Status
Change from base Build 5022019978: 0.04%
Covered Lines: 1934
Relevant Lines: 7553

💛 - Coveralls

@adrianchiris
Copy link
Collaborator Author

@e0ne @Eoghan1232 PTAL, this one is straight forward

Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

question: do you want them to have the same weight value assigned? this would mean the scheduler would check both at the same time, and choose whichever one is best to deploy on.
should one be a higher priority?

@adrianchiris
Copy link
Collaborator Author

question: do you want them to have the same weight value assigned? this would mean the scheduler would check both at the same time, and choose whichever one is best to deploy on.
should one be a higher priority?

in this case its fine to have both with same weight. generally in a cluster you would either have one set for control plane nodes or both.

latest deployments with kubeadm just set the control-plane label.
i kept the "master" label for backward compat.

@adrianchiris adrianchiris merged commit 497f285 into k8snetworkplumbingwg:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants