introduce a recheck for the VF interface name #720

SchSeba · 2024-06-20T14:17:07Z

It's possible to have a race in the VFIsReady function. vf netdevice can have a default eth0 device name and be the time we call the netlink syscall to get the device information eth0 can be a different device.

this cause duplicate mac allocation on vf admin mac address

github-actions · 2024-06-20T14:17:20Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba · 2024-06-20T14:17:37Z

cc @zeeke @adrianchiris
please take a look on this race condition

github-actions · 2024-06-21T12:20:24Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2024-06-21T12:26:26Z

Pull Request Test Coverage Report for Build 9613496848

Details

5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.05%) to 38.665%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/host/internal/sriov/sriov.go	5	6	83.33%

Files with Coverage Reduction	New Missed Lines	%
pkg/host/internal/sriov/sriov.go	1	44.09%

Totals
Change from base Build 9549902217:	0.05%
Covered Lines:	5185
Relevant Lines:	13410

💛 - Coveralls

zeeke · 2024-06-21T12:58:28Z

pkg/host/internal/sriov/sriov.go

-		return err == nil, nil
+
+		// try to get the interface name again and check if the name changed
+		vfName = s.networkHelper.TryGetInterfaceName(pciAddr)


The problem is that TryGetInterfaceName(pciAddr) might return eth0 value that is not unique for the system, and LinkByName('eth0') might return a different VF.

I'm not sure this would solve the problem 🤔

so the idea here was

getInterface name

vfLink object

getInterface name again

and we have two options here:
if the second time it's still eth0 this means the vfLink object we did before contains the right mac address(even if the VF will change name).
if the vf change is name we will try again

I think the problem is this:
suppose in the system there are two different VFs named eth0 (0000:19:00.5 and 0000:19:00.6) and we are calling VFIsReady("0000:19:00.5")

vfName = s.networkHelper.TryGetInterfaceName("0000:19:00.5") -> eth0
vfLink, err = s.netlinkLib.LinkByName(vfName) -> might return 0000:19:00.6

then
vfName = s.networkHelper.TryGetInterfaceName(pciAddr) still returns eth0

and the function will return the .6 netlink reference, instead of the .5 one. WDYT?

oh ok now I get your point the thing is that is not possible on a given time we can only have one interface with the same name that from the kernel lock system. some more info about that from our kernel developer

The interface name is assigned by the kernel during netdevice_register(). It is while holding the lock (rtnl_lock) and the kernel performs a name collision check. It is not possible to have two interfaces with the same name, but when eth0 is renamed to e.g. enp12s23, another device can use eth0 again, but not at the same time (rtnl_lock). The name of the device can be changed later (e.g. with the help of udev and this is also easily done, but again there is rtnl_lock which prevents collisions in names).

Oh, now it's much more clear, thanks.
So the scenario we are hitting here is a timeline like this:

Kernel create VF for 0000:d8:00.2 and call it eth0

udev rule change the name of 0000:d8:00.2 as eth0 -> eno1vf0

kernel create VF for 0000:d8:00.3 and call it eth0

So, before your changes it may happens the race condition:

Kernel create VF for 0000:d8:00.2 and call it eth0
a. VFIsReady(0000:d8:00.2)
b. TryGetInterfaceName(0000:d8:00.2) -> eth0

udev rule change the name of 0000:d8:00.2 as eth0 -> eno1vf0

kernel create VF for 0000:d8:00.3 and call it eth0
c. LinkByName(eth0) -> link for VF .3

And your proposing changes correctly address this case by

d. TryGetInterfaceName(0000:d8:00.2) -> eno1vf0
e. eth0 != eno1vf0
f. repeat the PollImmediate loop

is that correct?

adrianchiris · 2024-06-25T14:43:06Z

discussed in community meeting. we should modify the way we get the Link device by relying on interface index instead of name.

interface index is found under sysfs
/sys/bus/pci/deivces/<address>/net/<ifaceName/ifindex
if path does not exist we should retry (udev rule renamed interface)

github-actions · 2024-06-26T15:33:15Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba · 2024-06-26T15:33:55Z

/hold

waiting for k8snetworkplumbingwg/sriov-network-device-plugin#569

THIS PR CONTAINS A REPLACE IN GO MODS!

github-actions · 2024-06-26T15:47:26Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-06-27T15:03:42Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

adrianchiris · 2024-06-27T15:29:00Z

pkg/host/internal/network/network.go

 	return netDevName
 }

+// TryGetInterfaceName tries to find the SR-IOV virtual interface index base on pci address
+func (n *network) TryGetInterfaceIndex(pciAddr string) int {
+	ifIndex, err := n.dputilsLib.GetNetIndex(pciAddr)


you may get the wrong index in case of switched since implementation returns the first netdev interface index found.

in TryGetInterfaceNames , if in switchdev we return the "uplink representor" netdev. since in switchdev all representors (VF representors and uplink representor )will be found under the PF /net folder.

in device plugin we also have GetPFNames()[1] which also takes switchdev into account

[1] https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/blob/fe9f2f85553267c884dc1e68b94e8561c57e8c50/pkg/utils/utils.go#L72

github-actions · 2024-06-27T17:24:26Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2024-06-27T17:30:49Z

Pull Request Test Coverage Report for Build 9700937218

Details

25 of 62 (40.32%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 40.58%

Changes Missing Coverage	Changed/Added Lines	%
pkg/host/internal/lib/netlink/netlink.go	3	0.0%
pkg/helper/mock/mock_helper.go	10	0.0%
pkg/host/internal/network/network.go	24	0.0%

Totals
Change from base Build 9700329314:	0.003%
Covered Lines:	5538
Relevant Lines:	13647

💛 - Coveralls

coveralls · 2024-06-27T17:46:15Z

Pull Request Test Coverage Report for Build 9699009559

Details

25 of 64 (39.06%) changed or added relevant lines in 6 files are covered.
62 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.01%) to 40.389%

Changes Missing Coverage	Changed/Added Lines	%
pkg/host/internal/lib/netlink/netlink.go	3	0.0%
pkg/helper/mock/mock_helper.go	10	0.0%
pkg/host/internal/network/network.go	26	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/host/internal/lib/dputils/mock/mock_dputils.go	11	80.53%
pkg/host/internal/lib/dputils/dputils.go	13	9.09%
pkg/host/internal/network/network.go	38	44.44%

Totals
Change from base Build 9691456203:	0.01%
Covered Lines:	5480
Relevant Lines:	13568

💛 - Coveralls

coveralls · 2024-06-28T03:35:34Z

Pull Request Test Coverage Report for Build 9682784028

Details

25 of 64 (39.06%) changed or added relevant lines in 6 files are covered.
62 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.01%) to 40.389%

Changes Missing Coverage	Changed/Added Lines	%
pkg/host/internal/lib/netlink/netlink.go	3	0.0%
pkg/helper/mock/mock_helper.go	10	0.0%
pkg/host/internal/network/network.go	26	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/host/internal/lib/dputils/mock/mock_dputils.go	11	80.53%
pkg/host/internal/lib/dputils/dputils.go	13	9.09%
pkg/host/internal/network/network.go	38	44.44%

Totals
Change from base Build 9667839529:	0.01%
Covered Lines:	5480
Relevant Lines:	13568

💛 - Coveralls

SchSeba · 2024-06-28T09:52:52Z

/hold cancel

SchSeba · 2024-06-28T09:53:34Z

I switched the implementation to call the tryGetInterfaceName in the new function that way we don't need any new function in the sriov network device plugin.

ykulazhenkov · 2024-06-28T12:52:37Z

pkg/host/internal/sriov/sriov.go

@@ -189,12 +189,13 @@ func (s *sriov) VFIsReady(pciAddr string) (netlink.Link, error) {
 	var err error
 	var vfLink netlink.Link
 	err = wait.PollImmediate(time.Second, 10*time.Second, func() (bool, error) {
-		vfName := s.networkHelper.TryGetInterfaceName(pciAddr)
-		vfLink, err = s.netlinkLib.LinkByName(vfName)
+		vfIndex := s.networkHelper.TryGetInterfaceIndex(pciAddr)


Do we want to explicitly handle -1 result?

we didn't handle the empty interface name on TryGetInterfaceName so I was thinking it could be the same but I don't really care :)

adrianchiris · 2024-07-01T12:24:37Z

pkg/host/internal/network/network.go

 	return netDevName
 }

+// TryGetInterfaceName tries to find the SR-IOV virtual interface index base on pci address


nit: TryGetInterfaceIndex

adrianchiris · 2024-07-01T12:27:26Z

pkg/host/internal/network/network.go

 	return netDevName
 }

+// TryGetInterfaceName tries to find the SR-IOV virtual interface index base on pci address
+func (n *network) TryGetInterfaceIndex(pciAddr string) int {
+	ifName := n.TryToGetVirtualInterfaceName(pciAddr)


not related to this PR but shouldnt we merge the added logic in TryToGetVirtualInterfaceName into TryGetInterfaceName ?

sorry I used the wrong function here

adrianchiris · 2024-07-01T12:29:05Z

pkg/host/internal/network/network.go

+	}
+
+	netDir := filepath.Join(consts.SysBusPciDevices, pciAddr, "net", ifName)
+	if _, err := os.Lstat(netDir); err != nil {


do we really need this check ?

between here and L118 the path may no longer be valid when netdev name changes via udev right after this spot.

sounds right :)

adrianchiris · 2024-07-01T12:31:02Z

pkg/host/internal/network/network.go

 	return netDevName
 }

+// TryGetInterfaceName tries to find the SR-IOV virtual interface index base on pci address
+func (n *network) TryGetInterfaceIndex(pciAddr string) int {


any chance to add UT for this one ?

done both for this function and the vfIsReady function

ATM we dont use this method in a "Try" manner but rather fail on error (-1 returned)

WDYT about changing this one to: GetInterfaceIndex(pciAddr string) (int, error) ?
i think its better checking error obj than checking for -1.

sure done :)

github-actions · 2024-07-02T11:40:56Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2024-07-02T11:47:07Z

Pull Request Test Coverage Report for Build 9760276703

Details

41 of 61 (67.21%) changed or added relevant lines in 6 files are covered.
7 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.3%) to 40.939%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/host/internal/sriov/sriov.go	7	8	87.5%
pkg/host/internal/lib/netlink/netlink.go	0	3	0.0%
pkg/host/internal/network/network.go	13	19	68.42%
pkg/helper/mock/mock_helper.go	0	10	0.0%

Files with Coverage Reduction	New Missed Lines	%
controllers/drain_controller.go	1	68.06%
pkg/host/internal/sriov/sriov.go	1	55.4%
controllers/generic_network_controller.go	5	74.53%

Totals
Change from base Build 9745388570:	0.3%
Covered Lines:	5582
Relevant Lines:	13635

💛 - Coveralls

adrianchiris

final comment from my side otherwise LGTM

github-actions · 2024-07-02T13:09:09Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2024-07-02T13:16:46Z

Pull Request Test Coverage Report for Build 9761609394

Details

42 of 63 (66.67%) changed or added relevant lines in 6 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.4%) to 40.984%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/host/internal/sriov/sriov.go	7	8	87.5%
pkg/host/internal/lib/netlink/netlink.go	0	3	0.0%
pkg/host/internal/network/network.go	13	19	68.42%
pkg/helper/mock/mock_helper.go	0	11	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/host/internal/sriov/sriov.go	1	55.4%

Totals
Change from base Build 9745388570:	0.4%
Covered Lines:	5589
Relevant Lines:	13637

💛 - Coveralls

zeeke

LGTM

adrianchiris · 2024-07-02T13:32:46Z

pkg/host/internal/network/network.go

 	return netDevName
 }

+// TryGetInterfaceIndex tries to find the SR-IOV virtual interface index base on pci address


nit: please update comment :)

adrianchiris · 2024-07-02T13:33:04Z

pkg/host/internal/network/network.go

+	indexFile := filepath.Join(vars.FilesystemRoot, consts.SysBusPciDevices, pciAddr, "net", ifName, "ifindex")
+	ifIndex, err := os.ReadFile(indexFile)
+	if err != nil {
+		log.Log.Error(err, "TryGetInterfaceIndex(): failed to read ifindex file", "indexFile", indexFile)


nit: please update log msg

adrianchiris · 2024-07-02T13:33:13Z

pkg/host/internal/network/network.go

+
+	intIfIndex, err := strconv.Atoi(strings.TrimSpace(string(ifIndex)))
+	if err != nil {
+		log.Log.Error(err, "TryGetInterfaceIndex(): failed to parse ifindex file content", "ifIndex", string(ifIndex))


nit: please update log msg

adrianchiris · 2024-07-02T13:33:39Z

pkg/host/internal/network/network_test.go

@@ -238,4 +238,37 @@ var _ = Describe("Network", func() {
 			Expect(n.GetNetDevNodeGUID("0000:4b:00.3")).To(Equal("1122:3344:5566:7788"))
 		})
 	})
+	Context("TryGetInterfaceIndex", func() {


nit: please update name

github-actions · 2024-07-02T18:20:28Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2024-07-02T18:26:40Z

Pull Request Test Coverage Report for Build 9766049420

Details

42 of 63 (66.67%) changed or added relevant lines in 6 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.3%) to 40.947%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/host/internal/sriov/sriov.go	7	8	87.5%
pkg/host/internal/lib/netlink/netlink.go	0	3	0.0%
pkg/host/internal/network/network.go	13	19	68.42%
pkg/helper/mock/mock_helper.go	0	11	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/host/internal/sriov/sriov.go	1	55.4%
controllers/generic_network_controller.go	5	74.53%

Totals
Change from base Build 9745388570:	0.3%
Covered Lines:	5584
Relevant Lines:	13637

💛 - Coveralls

adrianchiris · 2024-07-03T06:42:27Z

pkg/host/internal/lib/netlink/netlink.go

@@ -24,6 +24,8 @@ type NetlinkLib interface {
 	LinkSetVfPortGUID(link Link, vf int, portguid net.HardwareAddr) error
 	// LinkByName finds a link by name and returns a pointer to the object.
 	LinkByName(name string) (Link, error)
+	// LinkByName finds a link by index and returns a pointer to the object.


just noticed this one :(. can you fix the typo

adrianchiris · 2024-07-03T06:47:04Z

pkg/host/internal/network/network.go

 	return netDevName
 }

+// GetInterfaceIndex tries to find the SR-IOV virtual interface index base on pci address


this function is not limited to SRIOV virtual interfaces as far as i can tell.

how about:
// GetInterfaceIndex returns network interface index base on pci address or error if occurred

It's possible to have a race in the VFIsReady function. vf netdevice can have a default eth0 device name and be the time we call the netlink syscall to get the device information eth0 can be a different device. this cause duplicate mac allocation on vf admin mac address Signed-off-by: Sebastian Sch <[email protected]>

github-actions · 2024-07-03T08:11:08Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2024-07-03T08:17:21Z

Pull Request Test Coverage Report for Build 9774215462

Details

42 of 63 (66.67%) changed or added relevant lines in 6 files are covered.
7 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.3%) to 40.94%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/host/internal/sriov/sriov.go	7	8	87.5%
pkg/host/internal/lib/netlink/netlink.go	0	3	0.0%
pkg/host/internal/network/network.go	13	19	68.42%
pkg/helper/mock/mock_helper.go	0	11	0.0%

Files with Coverage Reduction	New Missed Lines	%
controllers/drain_controller.go	1	68.06%
pkg/host/internal/sriov/sriov.go	1	55.4%
controllers/generic_network_controller.go	5	74.53%

Totals
Change from base Build 9774112825:	0.3%
Covered Lines:	5583
Relevant Lines:	13637

💛 - Coveralls

SchSeba · 2024-07-03T08:48:06Z

done with all the function names :P

can you please take another look?

SchSeba force-pushed the fix_race_condition branch from 632c827 to ad0b2f7 Compare June 21, 2024 12:20

zeeke reviewed Jun 21, 2024

View reviewed changes

zeeke mentioned this pull request Jun 26, 2024

Add GetNetIndex function to utils k8snetworkplumbingwg/sriov-network-device-plugin#569

Closed

SchSeba force-pushed the fix_race_condition branch from ad0b2f7 to 8615c37 Compare June 26, 2024 15:33

github-actions bot added the hold label Jun 26, 2024

SchSeba force-pushed the fix_race_condition branch from 8615c37 to 980e62f Compare June 26, 2024 15:47

SchSeba force-pushed the fix_race_condition branch from 980e62f to bc4a88e Compare June 27, 2024 15:03

adrianchiris reviewed Jun 27, 2024

View reviewed changes

SchSeba force-pushed the fix_race_condition branch from bc4a88e to 70f94bc Compare June 27, 2024 17:24

github-actions bot removed the hold label Jun 28, 2024

ykulazhenkov reviewed Jun 28, 2024

View reviewed changes

adrianchiris reviewed Jul 1, 2024

View reviewed changes

SchSeba force-pushed the fix_race_condition branch from 70f94bc to aa5e1a1 Compare July 2, 2024 11:40

adrianchiris reviewed Jul 2, 2024

View reviewed changes

SchSeba force-pushed the fix_race_condition branch from aa5e1a1 to 50db112 Compare July 2, 2024 13:08

zeeke approved these changes Jul 2, 2024

View reviewed changes

adrianchiris reviewed Jul 2, 2024

View reviewed changes

SchSeba force-pushed the fix_race_condition branch from 50db112 to ff1d3aa Compare July 2, 2024 18:20

adrianchiris reviewed Jul 3, 2024

View reviewed changes

SchSeba force-pushed the fix_race_condition branch from ff1d3aa to f8ce428 Compare July 3, 2024 08:10

adrianchiris approved these changes Jul 3, 2024

View reviewed changes

adrianchiris merged commit 2fed72e into k8snetworkplumbingwg:master Jul 3, 2024
13 checks passed

This was referenced Jul 5, 2024

OCPBUGS-36734,OCPBUGS-36733,OCPBUGS-36731,OCPBUGS-36730: 4.15 critical bugs openshift/sriov-network-operator#954

Merged

OCPBUGS-36753,OCPBUGS-36754,OCPBUGS-36755OCPBUGS-36756: [release-4.14] Critical Bugs openshift/sriov-network-operator#961

Merged

introduce a recheck for the VF interface name #720

introduce a recheck for the VF interface name #720

Conversation

SchSeba commented Jun 20, 2024

github-actions bot commented Jun 20, 2024

SchSeba commented Jun 20, 2024

github-actions bot commented Jun 21, 2024

coveralls commented Jun 21, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9613496848

Details

💛 - Coveralls

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adrianchiris commented Jun 25, 2024

github-actions bot commented Jun 26, 2024

SchSeba commented Jun 26, 2024

github-actions bot commented Jun 26, 2024

github-actions bot commented Jun 27, 2024

adrianchiris Jun 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 27, 2024

coveralls commented Jun 27, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9700937218

Details

💛 - Coveralls

coveralls commented Jun 27, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9699009559

Details

💛 - Coveralls

coveralls commented Jun 28, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9682784028

Details

💛 - Coveralls

SchSeba commented Jun 28, 2024

SchSeba commented Jun 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 2, 2024

coveralls commented Jul 2, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9760276703

Details

💛 - Coveralls

adrianchiris left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 2, 2024

coveralls commented Jul 2, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9761609394

Details

💛 - Coveralls

zeeke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 2, 2024

coveralls commented Jul 2, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9766049420

Details

💛 - Coveralls

coveralls commented Jun 21, 2024 •

edited

Loading

adrianchiris Jun 27, 2024 •

edited

Loading

coveralls commented Jun 27, 2024 •

edited

Loading

coveralls commented Jun 27, 2024 •

edited

Loading

coveralls commented Jun 28, 2024 •

edited

Loading

SchSeba commented Jun 28, 2024 •

edited

Loading

coveralls commented Jul 2, 2024 •

edited

Loading

coveralls commented Jul 2, 2024 •

edited

Loading

coveralls commented Jul 2, 2024 •

edited

Loading

coveralls commented Jul 3, 2024 •

edited

Loading