Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlapping ranges check to network_name feature #355

Conversation

andreaskaris
Copy link
Contributor

@andreaskaris andreaskaris commented Jun 19, 2023

a) Add overlapping ranges check to network_name feature

The network_name feature lacked integration for parameter
enable_overlapping_ranges which had to be set to off. Add support for
this parameter to networks with a non-default network_name by creating
overlappingipreservations which are prefixed with the network_name.

b) Add documentation for parameter network_name in README.md

c) Add E2E tests for OverlappingRangeIPReservation

Special notes for your reviewer (optional):
This should complete the requirements for OpenShift RFE https://issues.redhat.com/browse/RFE-3321?

Signed-off-by: Andreas Karis <[email protected]>
@andreaskaris andreaskaris changed the title Network name overlappingipreservations Add overlapping ranges check to network_name feature Jun 19, 2023
@andreaskaris andreaskaris force-pushed the network-name-overlappingipreservations branch 3 times, most recently from a3f97b7 to b78ddbb Compare June 19, 2023 19:29
The network_name feature lacked integration for parameter
enable_overlapping_ranges which had to be set to off. Add support for
this parameter to networks with a non-default network_name by creating
overlappingipreservations which are prefixed with the network_name.

Signed-off-by: Andreas Karis <[email protected]>
@andreaskaris andreaskaris force-pushed the network-name-overlappingipreservations branch from b78ddbb to f4a278e Compare June 19, 2023 19:32
@andreaskaris
Copy link
Contributor Author

@dougbtv

Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a solid addition, and the approach is very efficient. Thank you for the docs and e2e tests as well.

@dougbtv dougbtv merged commit 9b72da8 into k8snetworkplumbingwg:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants