Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rechecking pending Pods (conflict resolved) #372

Closed

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Aug 3, 2023

This is a rebase of #195

Notably it's failing:

------------------------------
• Failure [1.504 seconds]
Whereabouts IP reconciler
/home/doug/codebase/src/github.com/dougbtv/whereabouts/pkg/reconciler/ip_test.go:34
  a pod in pending state, without an IP in its network-status
  /home/doug/codebase/src/github.com/dougbtv/whereabouts/pkg/reconciler/ip_test.go:311
    cannot be reconciled [It]
    /home/doug/codebase/src/github.com/dougbtv/whereabouts/pkg/reconciler/ip_test.go:334

    Expected
        <[]net.IP | len:1, cap:1>: [
            [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 255, 255, 10, 10, 10, 1],
        ]
    to be empty

    /home/doug/codebase/src/github.com/dougbtv/whereabouts/pkg/reconciler/ip_test.go:335

@nicklesimba
Copy link
Collaborator

Closing this pr in favor of #375

@nicklesimba nicklesimba closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants