Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable cron schedule for reconciler #398

Merged
merged 10 commits into from
Jan 2, 2024
Merged

Configurable cron schedule for reconciler #398

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6684139
Extended support for customizing whereabouts ip-reconciler cron schedule
nicklesimba Nov 22, 2023
061b1ac
crd: fix & rename
maiqueb Dec 20, 2023
4136684
build: update gocron to v2
maiqueb Dec 20, 2023
0862419
build: build container w/ golang 1.20
maiqueb Dec 20, 2023
e0625d9
reconciler: react to cron expr updates
maiqueb Dec 20, 2023
f67b5ce
reconciler: sort out the reconciler error codes
maiqueb Dec 20, 2023
da358de
reconciler: only read from flatfile if config is not present
maiqueb Dec 22, 2023
58ba24c
reconciler: add a configuration watcher pkg
maiqueb Dec 22, 2023
40ea8de
reconciler: provide a job factory func
maiqueb Dec 22, 2023
01e8c80
docs: clean up some leftovers
maiqueb Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions cmd/controlloop/controlloop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,13 @@ const (
)

const (
couldNotCreateController = 1
couldNotReadFlatfile = 1
couldNotGetFlatIPAM = 1
cronExpressionError = 1
_ int = iota
couldNotCreateController
couldNotGetFlatIPAM
cronExpressionError
cronSchedulerCreationError
fileWatcherError
fileWatcherAddWatcherError
)

const (
Expand Down Expand Up @@ -70,7 +73,7 @@ func main() {

s, err := gocron.NewScheduler(gocron.WithLocation(time.UTC))
if err != nil {
os.Exit(123)
os.Exit(cronSchedulerCreationError)
}
schedule := determineCronExpression()

Expand All @@ -91,14 +94,14 @@ func main() {
watcher, err := fsnotify.NewWatcher()
if err != nil {
_ = logging.Errorf("error creating configuration watcher: %v", err)
os.Exit(321)
os.Exit(fileWatcherError)
}
defer watcher.Close()

go syncConfiguration(watcher, s, job, errorChan)
if err := watcher.Add(reconcilerCronConfiguration); err != nil {
_ = logging.Errorf("error adding watcher to config %q: %v", reconcilerCronConfiguration, err)
os.Exit(1234)
os.Exit(fileWatcherAddWatcherError)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it :) ok now I see what's up. thanks, perfect

}

for {
Expand Down
Loading