-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Go version 1.23 #512
Bump Go version 1.23 #512
Conversation
mlguerrero12
commented
Oct 15, 2024
•
edited
Loading
edited
- Align with version used in Dockerfile
- Workflows use go version set in go.mod
- Fix overlappingiprange test
fbdefb4
to
dec97f4
Compare
Pull Request Test Coverage Report for Build 11436559402Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I see a failing e2e so I tried restarting it in case it's a flake
dec97f4
to
f177fe1
Compare
It seems to be a consistent issue. I will investigate |
Signed-off-by: Marcelo Guerrero <[email protected]>
Align with version used in Dockerfile Signed-off-by: Marcelo Guerrero <[email protected]>
Signed-off-by: Marcelo Guerrero <[email protected]>
f177fe1
to
f17422d
Compare
@dougbtv, I fixed the overlappingiprange test. It was constantly failing on my local setup as well. This test has a for loop that sets the var Please have a look again. |