Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version 1.23 #512

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

mlguerrero12
Copy link
Collaborator

@mlguerrero12 mlguerrero12 commented Oct 15, 2024

  • Align with version used in Dockerfile
  • Workflows use go version set in go.mod
  • Fix overlappingiprange test

@coveralls
Copy link

coveralls commented Oct 15, 2024

Pull Request Test Coverage Report for Build 11436559402

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-15.5%) to 38.639%

Totals Coverage Status
Change from base Build 11386936224: -15.5%
Covered Lines: 1971
Relevant Lines: 5101

💛 - Coveralls

Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I see a failing e2e so I tried restarting it in case it's a flake

@mlguerrero12
Copy link
Collaborator Author

It seems to be a consistent issue. I will investigate

Align with version used in Dockerfile

Signed-off-by: Marcelo Guerrero <[email protected]>
@mlguerrero12
Copy link
Collaborator Author

@dougbtv, I fixed the overlappingiprange test. It was constantly failing on my local setup as well. This test has a for loop that sets the var enableOverlappingRanges to true or false. Based on this, it checks if the ips of the pods are equal or different. The issue is that it never created the new NAD using this var. It was always false. So, it ran the same scenario but with different checks at the end. Did not investigate why this test has been passing. It's a bit strange, but it is good now.

Please have a look again.

@dougbtv dougbtv merged commit 53ace55 into k8snetworkplumbingwg:master Oct 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants