-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make tolerations configurable #46
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A couple of comments for your review.
tolerations: | ||
description: Tolerations applied to the Reaper pods | ||
items: | ||
description: The pod this Toleration is attached to tolerates any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tolerates -> tolerate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That description comes from the Toleration docs which is part of the core k8s api.
set, which means tolerate the taint forever (do not evict). | ||
Zero and negative values will be treated as 0 (evict immediately) | ||
by the system. | ||
format: int64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format seems a bit high at int64 since it allows for not setting a value to tolerate the taint forever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. This is part of the core Toleration type.
Needed for k8ssandra/k8ssandra#698.