Should I require set +e even after this change?

kachick · Nov 1, 2024 · c2cddc8 · c2cddc8
1 parent 51faa13
commit c2cddc8
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/.github/workflows/notify-nixpkgs-news.yml b/.github/workflows/notify-nixpkgs-news.yml
@@ -73,8 +73,10 @@ jobs:
           set -x
 
           # Passing example for test
-          [[ '${{ needs.detect.outputs.GH-846 }}' == 'true' ]] && \
+          if [[ '${{ needs.detect.outputs.GH-846 }}' == 'true' ]]; then
             gh issue comment '846' --body "🤖(GH-846): https://github.com/NixOS/nixpkgs/tree/nixos-unstable looks like merged https://github.com/NixOS/nixpkgs/commit/3137334d7556e24e3f582681142e505b4d7915a8"
+          fi
 
-          [[ '${{ needs.detect.outputs.GH-902 }}' == 'true' ]] && \
+          if [[ '${{ needs.detect.outputs.GH-902 }}' == 'true' ]]; then
             gh issue comment '902' --body "🤖(GH-846): https://github.com/NixOS/nixpkgs/tree/nixos-unstable looks like merged https://github.com/NixOS/nixpkgs/commit/67d8538ef6a8b6933de55c09dfcad679a5618868"
+          fi