Windows CI does not respect failing exit code

[kachick]

actions/runner#351

I didn't notice some errors caused on this problem

https://github.com/kachick/dotfiles/actions/runs/9265658345/job/25488151731

C:\Users\runneradmin\Documents\PowerShell\Microsoft.PowerShell_profile.ps1
2024/05/28 08:03:1[7](https://github.com/kachick/dotfiles/actions/runs/9265658345/job/25488151731#step:14:8) config/starship/starship.toml => C:\Users\runneradmin\.config\starship.toml
2024/05/2[8](https://github.com/kachick/dotfiles/actions/runs/9265658345/job/25488151731#step:14:9) 08:03:17 config/wezterm/wezterm.lua => C:\Users\runneradmin\.config\wezterm\wezterm.lua
2024/05/28 08:03:17 Failed to copy file: {FS:{files:0x10f5780} EmbedTree:[config wezterm wezterm.lua] DstTree:[C:\Users\runneradmin .config wezterm wezterm.lua]} open C:\Users\runneradmin\.config\wezterm\wezterm.lua: The system cannot find the path specified.

This error continue the workflow

[kachick]

But the above issue saying 42 will be 1, not 0.

My workaround for pwsh exit code in another repository

https://github.com/kachick/PSFzfHistory/blob/48bce024622c0837d7220dba5c37aad39e16651e/Taskfile.yml#L17-L19
https://github.com/kachick/PSFzfHistory/blob/48bce024622c0837d7220dba5c37aad39e16651e/tools/test-all.ps1#L1-L5

[kachick]

Microsoft does much simple way 🙄

https://github.com/microsoft/hcsshim/blob/c6e7159431112fe8949824eef4e7e884fe648266/.github/workflows/ci.yml#L322

          if ($LASTEXITCODE -ne 0) {
            Write-Output "::error title=Go Generate::Error running go generate."
            exit $LASTEXITCODE
          }

in all place

It is described in https://stackoverflow.com/a/69616921

[kachick]

Hmm... simply adding does not fix. actions/runner-images#6668

[kachick]

Ah... it requires for each command, not for all run... 🙄

[kachick]

https://github.com/github/docs/blob/08b31e6a5c091c99940b6cc8dae464e873006c33/content/actions/writing-workflows/workflow-syntax-for-github-actions.md?plain=1#L773-L776

[kachick]

https://github.com/mattiasw/ExifReader/blob/b4652d357d410b876215bfadfcdc3152128b4e7a/.github/workflows/nodejs.yml#L71
https://github.com/microsoft/hcsshim/blob/c6e7159431112fe8949824eef4e7e884fe648266/.github/workflows/ci.yml#L465-L466

[kachick]

In summary, how to realize set -o errexit in pwsh? 🤔

https://stackoverflow.com/a/57949447

[kachick]

https://learn.microsoft.com/en-us/powershell/scripting/learn/experimental-features?view=powershell-7.4#psnativecommanderroractionpreference

PSNativeCommandErrorActionPreference

This feature became mainstream in PowerShell 7.4.

[kachick]

Suggestion for that actions/runner-images#8900

[kachick]

💭 I had a typo, because of confusion against similar names.

• PSNativeCommandErrorActionPreference is the feature name.
• $PSNativeCommandUseErrorActionPreference is the variable.
• $PSNativeCommandErrorActionPreference is my typo.