Skip to content

Commit

Permalink
Merge pull request #551 from kachick/fix-dropped-bundle-without
Browse files Browse the repository at this point in the history
Add unexpectedly dropped BUNDLE_WITHOUT again
  • Loading branch information
kachick committed May 31, 2024
2 parents deefb57 + d288cc3 commit e8ac765
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ jobs:
# Due to https://github.com/actions/runner/issues/849, we have to use quotes for 'n.0'
ruby: ['head', '3.3', '3.2']
runs-on: ${{ matrix.os }}
env:
# https://github.com/kachick/ruby-ulid/blob/104834846baf5caa1e8536a11c43acdd56fc849c/CONTRIBUTING.md#adding-dependencies-for-this-gem
BUNDLE_WITHOUT: development
steps:
# libyaml is needed for psych, see https://github.com/actions/runner-images/issues/9895
# GitHub installs libyaml-dev in latest runners, but often dropped in new runners.
Expand All @@ -46,16 +49,10 @@ jobs:
run: sudo apt-get install --no-install-recommends --assume-yes libyaml-dev
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@943103cae7d3f1bb1e4951d5fcc7928b40e4b742 # v1.177.1
env:
# https://github.com/kachick/ruby-ulid/blob/104834846baf5caa1e8536a11c43acdd56fc849c/CONTRIBUTING.md#adding-dependencies-for-this-gem
BUNDLE_WITHOUT: development
with:
ruby-version: ${{ matrix.ruby }}
# Enabling is the recommended way, but it cannot detect runner changes in early stage.
# So disable it is better for test job, do not mind in other jobs
bundler-cache: false # runs 'bundle install' and caches installed gems automatically
- run: bundle install
- run: bundle exec rake test_all --suppress-backtrace='\/bundle'
env:
# Need same specifying for now(want to squash)
BUNDLE_WITHOUT: development

0 comments on commit e8ac765

Please sign in to comment.