Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ULID#patterns instead of ULID#pattern and ULID#strict_pattern #84

Closed
kachick opened this issue May 5, 2021 · 0 comments · Fixed by #99
Closed

Provide ULID#patterns instead of ULID#pattern and ULID#strict_pattern #84

kachick opened this issue May 5, 2021 · 0 comments · Fixed by #99
Labels
enhancement New feature or request

Comments

@kachick
Copy link
Owner

kachick commented May 5, 2021

I applied ULID#pattern and ULID#strict_pattern in #35.

But related Regexp might be many patterns.

So providing it as collection as a Hash might be better, I think 🤔

Then considering cache strategy for them. Keeping Hash in all instance and compiles Regexp in freezing sounds needless and heavy.... They simply returns new Hash[Symbol, Regexp] when called the methods looks reasonable.

@kachick kachick added the enhancement New feature or request label May 5, 2021
kachick added a commit that referenced this issue May 5, 2021
@kachick kachick changed the title Provide ULID#patterns Provide ULID#patterns instead of ULID#pattern and ULID#strict_pattern May 5, 2021
@kachick kachick mentioned this issue May 5, 2021
9 tasks
kachick added a commit that referenced this issue May 7, 2021
kachick added a commit that referenced this issue May 7, 2021
kachick added a commit that referenced this issue May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant