Migrate to TypeScript 5 (#453)

* Update tsconfig and eslint config for TS5 era

* `npm uninstall typescript && npm install --save-dev typescript`

* `npm uninstall @tsconfig/node16-strictest-esm`

* Update jest config and code for TS5

.eslintrc.yml

@@ -33,6 +33,9 @@ rules:
   '@typescript-eslint/prefer-readonly-parameter-types':
     - error
     - ignoreInferredTypes: true
+  # See https://zenn.dev/teppeis/articles/2023-04-typescript-5_0-verbatim-module-syntax for enabling reason
+  '@typescript-eslint/consistent-type-imports': 'error'
+  '@typescript-eslint/no-import-type-side-effects': 'error'
 parser: '@typescript-eslint/parser'
 parserOptions:
   ecmaVersion: 12

__tests__/postbuild/main.test.ts

@@ -1,5 +1,6 @@
 import { env, execPath } from 'process';
-import { execFileSync, ExecFileSyncOptions } from 'child_process';
+import type { ExecFileSyncOptions } from 'child_process';
+import { execFileSync } from 'child_process';
 import { join } from 'path';
 import { expect, test } from '@jest/globals';
 

jest.post.config.ts

@@ -17,4 +17,4 @@ const config: Config.InitialOptions = {
   extensionsToTreatAsEsm: ['.ts'],
   testMatch: ['**/__tests__/postbuild/**/*.test.ts'],
 };
-export default config;
+module.exports = config;

jest.pre.config.ts

@@ -17,4 +17,4 @@ const config: Config.InitialOptions = {
   extensionsToTreatAsEsm: ['.ts'],
   testMatch: ['**/__tests__/prebuild/**/*.test.ts'],
 };
-export default config;
+module.exports = config;

package.json

@@ -33,7 +33,6 @@
   },
   "devDependencies": {
     "@octokit/types": "^9.0.0",
-    "@tsconfig/node16-strictest-esm": "^1.0.3",
     "@types/jest": "^29.5.0",
     "@types/node": "^16.18.23",
     "@typescript-eslint/eslint-plugin": "^5.58.0",
@@ -46,6 +45,6 @@
     "jest": "^29.5.0",
     "ts-node": "^10.9.1",
     "tsx": "^3.12.6",
-    "typescript": "^4.9.5"
+    "typescript": "^5.0.4"
   }
 }

tsconfig.base.json

@@ -0,0 +1,30 @@
+{
+  // Import from https://github.com/tsconfig/bases/commit/0ae4791797d8ba3dd2bca9aca880eb2d3e30e6fb
+  // To avoid issues around tsconfig.extends array
+  "$schema": "https://json.schemastore.org/tsconfig",
+  "display": "Node 16 + Strictest",
+  "compilerOptions": {
+    "lib": [
+      "es2021"
+    ],
+    "module": "commonjs",
+    "target": "es2021",
+    "strict": true,
+    "esModuleInterop": true,
+    "skipLibCheck": true,
+    "forceConsistentCasingInFileNames": true,
+    "moduleResolution": "node",
+    "allowUnusedLabels": false,
+    "allowUnreachableCode": false,
+    "exactOptionalPropertyTypes": true,
+    "noFallthroughCasesInSwitch": true,
+    "noImplicitOverride": true,
+    "noImplicitReturns": true,
+    "noPropertyAccessFromIndexSignature": true,
+    "noUncheckedIndexedAccess": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "verbatimModuleSyntax": true,
+    "checkJs": true
+  }
+}

tsconfig.json

@@ -1,6 +1,6 @@
 {
-  // https://github.com/tsconfig/bases/blob/d1543a94d47c3ef9af9987790742b09caf71b71d/bases/node16-strictest-esm.combined.json
-  "extends": "@tsconfig/node16-strictest-esm/tsconfig.json",
+  // TODO: Use tsconfig/base after all tools support tsconfig.extends array
+  "extends": "./tsconfig.base.json",
   "compilerOptions": {
     // https://www.typescriptlang.org/docs/handbook/esm-node.html
     "module": "node16",