Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Brokers: Configs: Improvements #179

Merged
merged 15 commits into from
Mar 12, 2024
Merged

FE: Brokers: Configs: Improvements #179

merged 15 commits into from
Mar 12, 2024

Conversation

Leshe4ka
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Leshe4ka Leshe4ka added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes labels Feb 28, 2024
@Leshe4ka Leshe4ka self-assigned this Feb 28, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 28, 2024
@Leshe4ka Leshe4ka requested a review from Mgrdich March 1, 2024 12:39
@Haarolean Haarolean linked an issue Mar 1, 2024 that may be closed by this pull request
@Haarolean Haarolean self-requested a review March 3, 2024 04:02
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's display size and time units formatted (e.g. 102400 bytes -> 1024 kB). There's an example code used in BytesFormatted component we used elsewhere.
  2. Let's not apply formatting for the negative values (currently I see some rows with "-1 bytes")
  3. If we're moving the sorting out of the scope of this issue, let's create a separate issue explaining what's left to do

@Leshe4ka Leshe4ka merged commit 14084f4 into main Mar 12, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brokers: Configs: Improvements
3 participants