Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check on Streams User deserialization that requires a topics.r… #540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -427,17 +427,6 @@ private Optional<PlatformSystem> doStreamsElements(JsonParser parser, JsonNode n
+ " might require both read and write topics as per its "
+ "nature it is always reading and writing into Apache Kafka, be aware if you notice problems.");
}
if (topics.get(KStream.READ_TOPICS).isEmpty()) {
// should have at minimum read topics defined as we could think of write topics as internal
// topics being
// auto created.
throw new IOException(
"Kafka Streams application with Id "
+ ks.getApplicationId()
+ " and principal "
+ ks.getPrincipal()
+ " have missing read topics. This field is required.");
}
}
return Optional.of(new PlatformSystem(streams));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,6 @@ public void testStreamsParsingOnlyReadTopicsShouldNotParseAsNull() {
}
}

@Test(expected = TopologyParsingException.class)
public void testStreamsParsingOnlyWriteTopicsShoulRaiseAnException() {
parser.deserialise(TestUtils.getResourceFile("/descriptor-streams-only-write.yaml"));
}

@Test
public void testDynamicFirstLevelAttributes() {
Topology topology =
Expand Down
11 changes: 0 additions & 11 deletions src/test/resources/descriptor-streams-only-write.yaml

This file was deleted.