Handle consumer groups with new client #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ended up being surprisingly easy. Where I got hung up before is that the new client doesn't know about any topics by default (fetching all topics for a large cluster can cause timeouts), but it needs to know about the topics that belong to the consumer group. So I added an `initial_topics` setting for the new client's initialization and pass that in from the consumer group set up. The old client will just ignore this setting.
dantswain
commented
Aug 22, 2019
| @@ -698,7 +703,7 @@ defmodule KafkaEx.GenConsumer do | |||
| end | |||
|
|
|||
| case response do | |||
| %{last_offset: nil, message_set: []} -> | |||
There was a problem hiding this comment.
I'm not sure why we were matching on this before. The new client passes the actual last offset even if the message set is empty.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up being surprisingly easy. Where I got hung up before is
that the new client doesn't know about any topics by default (fetching
all topics for a large cluster can cause timeouts), but it needs to know
about the topics that belong to the consumer group. So I added an
initial_topicssetting for the new client's initialization and passthat in from the consumer group set up. The old client will just ignore
this setting.