Allow specifying API version for produce/fetch with new client, support timestamps #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to specify what format messages we want to receive
I borked the previous commit
I r bad at git
Merged
esambo
reviewed
Mar 4, 2023
| defstruct key: nil, value: nil | ||
| @type t :: %Message{key: binary, value: binary} | ||
| defstruct key: nil, value: nil, timestamp: nil | ||
| @type t :: %Message{key: binary, value: binary, timestamp: integer} |
There was a problem hiding this comment.
shouldn't the timestamp be optional?
Suggested change
| @type t :: %Message{key: binary, value: binary, timestamp: integer} | |
| @type t :: %Message{key: binary, value: binary, timestamp: integer | nil} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The produce and fetch commands now accept an
api_versionoption that will be used only with the new Kayrock-based client to send the appropriate-versioned message.This is important for compatibility with newer versions of Kafka that use the more efficient RecordBatch message storage format. The existing KafkaEx code always sends a v0 fetch request, which will force the broker to convert fetched messages, which can lead to very high CPU load on the broker.
I also added support for timestamps with the appropriate api versions.
I added a pile of test cases for various combinations of produce/fetch versions, compression settings, and timestamp settings.