Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the offset commit api version on fetch requests #370

Merged
merged 1 commit into from
Oct 6, 2019

Conversation

dantswain
Copy link
Collaborator

This only matters for auto_commit, but I realized that was being
hard-coded to v0 and people would probably not like that.

This only matters for auto_commit, but I realized that was being
hard-coded to v0 and people would probably not like that.
Copy link
Member

@joshuawscott joshuawscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dantswain dantswain merged commit 9400a17 into master Oct 6, 2019
@dantswain dantswain deleted the offset_commit_api_version_auto_commit branch October 6, 2019 16:39
@joshuawscott joshuawscott mentioned this pull request Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants