Fix default partitioner for kayrock #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported on slack by @bartek - the default partitioner (really any partitioner) needs to know how many partitions a topic has. In the Kayrock-based client, we don't automatically fetch metadata for every topic. So it becomes a problem if anyone tries to produce to a topic that the client doesn't know about yet. This should fix that by ensuring we have topic metadata for any topic to which we produce.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on slack by @bartek - the default partitioner (really any
partitioner) needs to know how many partitions a topic has. In the
Kayrock-based client, we don't automatically fetch metadata for every
topic. So it becomes a problem if anyone tries to produce to a topic
that the client doesn't know about yet.
This should fix that by ensuring we have topic metadata for any topic
to which we produce.