Translate int size values into module attributes #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @habutre! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
This commit aim to review possible uses of binary concatenation rather than iolist concat that according with outcomes from issues kafkaex#231 and kafkaex#290 had proofed to be more efficient In the end any other binary concat were found, but some small changes will be proposed as follows: 1. The Common module was returning a empty string instead empty iolist on `topic_data([])`, there is not big improvements here but a normalization among protocol modules 2. Replace literal integer size values to meaningful module attributes on Produce module
habutre
force-pushed
the
iodata-on-protocols
branch
from
3272477
to
1ca9cc9
Compare
|
Thanks for the PR, can you please update the title of the PR to reflect the work done in the body of the PR. |
habutre
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aim to review possible uses of binary concatenation rather
than iolist concat that according with outcomes from issues #231 and #290
had proofed to be more efficient
In the end no other binary concat were found, but some small changes will
be proposed as follows:
KafkaEx.Protocol.Commonmodule was returning a empty string instead of empty iolist ontopic_data([])fun, there is not big improvements here but a normalization among protocol modulesKafkaEx.Protocol.DeleteTopics