Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow GenConsumer callbacks to return :stop replies #424

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Allow GenConsumer callbacks to return :stop replies #424

merged 2 commits into from
Jan 7, 2021

Conversation

hairyhum
Copy link
Contributor

This should allow to gracefully stop consumers from the handler module (e.g. on certain messages)

joshuawscott
joshuawscott approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@joshuawscott joshuawscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

jbruggem
jbruggem approved these changes Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@jbruggem jbruggem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuawscott joshuawscott merged commit 1d8c0e5 into kafkaex:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuawscott joshuawscott joshuawscott approved these changes

@jbruggem jbruggem jbruggem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hairyhum @joshuawscott @jbruggem