Support pre registered schemas #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the method `getRegistryIdBySchema` to fetch a registry id for a pre-registered schema. If the subject or schema does not exist in the registry, it throws an error. Fixes #56
erikengervall
approved these changes
Apr 13, 2020
| @@ -38,6 +38,7 @@ export type SchemaRegistryAPIClient = Client<{ | |||
| config: (_: any) => any | |||
| updateConfig: (_: any) => any | |||
| register: (_: any) => any | |||
| registered: (_: any) => any | |||
There was a problem hiding this comment.
I cry a bit inside every time I see this 😅At least it's not exposed to the user 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the method
getRegistryIdBySchemato fetch a registry id for a pre-registered schema. If the subject or schema does not exist in the registry, it throws an error.I haven't documented it, because then I'll get a conflict with my other PR. I can add it later when they are merged.
Fixes #56