-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements graph in logging #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great :) thank you for covering a big part of the logging functionality
Had cursory look, and I had just have a few comments. I will test the functionality more thoroughly later
Apparently stdout can read the color if it is forced with |
separates logEntry and commits in logEntry model
Fixes #38
This PR implements the graph output in logging by executing raw git log commands directly to get the graph output like magit. That allows us to implement many switches that isn't possible with the git api provided by vscode.
Implemented:
-g
)l
for current,o
for other,h
forHEAD
,L
for all local branches,b
for all branches, anda
for all references-g
), decoration (-d
), and simplify by decoration(`-D)l
) option with detached HEADo
) option with default placeholder,
orInconsistencies/Features still missing in logging:
--color
, and needs more input parsing, and a way to display color in a text doc)-n
or-F
(This requires more refactoring work with the switch code structure. This refactoring should allow multiple types of follow up input box)--graph
)This PR by itself should be ready, I am only listing the missing feature here just to track what else is needed to be done for logging to be feature complete