fix min update break chapter issue #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1
Overview
低負荷更新で目次の章が破損する
Causes
EpisodeFecher.moveNextで目次ページhtmlから章と話を読み込んでいるEpisodeFecher.mChapter)Solutions
UpdateManagerのloadEpisodeメソッド(private) でNovelBeanオブジェクト をアップデートすることで確認できるNovelBean.getChapter()メソッドで入手できるEpisodeFecherのmChapterフィールドを更新するToDo
Modding.patchNovelHtml(目次ページhtml連結用メソッド) で、低負荷更新時に読込み開始話番号をListBeanオブジェクトに記録するprivate int ListBean.updateStartNoフィールドとsetter/getterを作成UpdateManagerクラスでEpisodeFetcherオブジェクト作成後に上記updateStartNoを利用してupdateStartNo - 1話の章番号をロード、EpisodeFecher.mChapterを更新EpisodeFecher.mChapterにはsetterがないため追加UpdateMangerのprivate要素を複数参照するため、Moddingクラスのstaticメソッドではなく、UpdateManagerのメソッドmodEpisodeFetcherChapterとして追加する