-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kairos dockerfiles should create full kairos images #1897
Comments
Better merge this first: #1939 |
Merged
jimmykarily
added a commit
that referenced
this issue
Oct 24, 2023
moved here: #1897 (comment) Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
added a commit
that referenced
this issue
Oct 24, 2023
moved here: #1897 (comment) Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
added a commit
that referenced
this issue
Oct 24, 2023
moved here: #1897 (comment) Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
added a commit
that referenced
this issue
Oct 24, 2023
* Refactor flavors and dockerfiles Fixes #1898 Signed-off-by: Dimitris Karakasilis <[email protected]> * Use FRAMEWORK_FLAVOR variable to avoid confusion with FLAVOR Signed-off-by: Dimitris Karakasilis <[email protected]> * Fix pipeline by adding mandatory value Signed-off-by: Dimitris Karakasilis <[email protected]> * Fix ubuntu Dockerfile Signed-off-by: Dimitris Karakasilis <[email protected]> * Apply suggestions from code review Signed-off-by: Dimitris Karakasilis <[email protected]> * Remove TODO (already implemented) and non-used ARG "IMAGE" Signed-off-by: Dimitris Karakasilis <[email protected]> * Remove TODOs moved here: #1897 (comment) Signed-off-by: Dimitris Karakasilis <[email protected]> * Remove unecessary env variables and fix VARIANT_RELEASE missing Signed-off-by: Dimitris Karakasilis <[email protected]> * PR comments Signed-off-by: Dimitris Karakasilis <[email protected]> * Remove naming.sh script from base image Signed-off-by: Dimitris Karakasilis <[email protected]> * Make sure we use the "fixed" kairos version with the remove "+" symbols when creating a tag for container images. Signed-off-by: Dimitris Karakasilis <[email protected]> * Setup qemu and docker buildx in reusable-build-flavor workflow because otherwise it fails to build rpi images Signed-off-by: Dimitris Karakasilis <[email protected]> * Remove not needed env variables Signed-off-by: Dimitris Karakasilis <[email protected]> * Remove temporary change Signed-off-by: Dimitris Karakasilis <[email protected]> --------- Signed-off-by: Dimitris Karakasilis <[email protected]> Signed-off-by: Dimitris Karakasilis <[email protected]> Co-authored-by: Mauro Morales <[email protected]>
This was referenced Oct 30, 2023
I will better not merge since it makes it less explicit for some of the actions in which distro they should be run and in which not |
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we build the Dockerfiles, and then we do many more things in Earthly.
All this logic can be moved to the Dockerfiles. This will allow the creation of other derivatives without any Earthly knowledge.
Items extracted from TODOs (#1912):
The text was updated successfully, but these errors were encountered: