Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Split elemental-cli into a lifecycle manager for the system (install/upgrade) and a building component #711

Closed
6 tasks done
Tracked by #116 ...
mudler opened this issue Jan 24, 2023 · 5 comments
Closed
6 tasks done
Tracked by #116 ...
Assignees
Labels
lane/factory MVP refactoring Areas of code that needs refactoring, or have a technical debt

Comments

@mudler
Copy link
Member

mudler commented Jan 24, 2023

The building bits should be part of osbuilder, and renamed accordingly.

This is a "cosmetical change" as the lib will still be in one place, and just the cmd/bin starters

Image

Action items

  • Extract the building functionality to a new binary
  • Use the new "building" binary in osbuilder and auroraboot (instead of elemental-cli). osbuilder/auroraboot should no longer depend on elemental-cli (just the new binary).
  • Rename elemental-cli to something that reflects its "installer/upgrader" nature.
  • Use the new "installer/upgrader" binary in kairos (replacing elemental-cli everywhere). For a couple of releases, let's maintain a symlink pointing elemental-cli to the new binary. We should show a deprecation warning.
  • Adapt the architecture docs which refers to elemental-toolkit and elemental-cli and adapt accordingly.
  • get rid of manual pinning here: https://github.com/kairos-io/osbuilder/blob/d8a56badc11aa1a9f797e45ff82c813075f41ed8/tools-image/Dockerfile#L26
@mudler mudler mentioned this issue Feb 22, 2023
35 tasks
@mudler mudler changed the title Split elemental-cli into a lifecycle manager for the system (install/upgrade) and a building component 🌱 Split elemental-cli into a lifecycle manager for the system (install/upgrade) and a building component Mar 6, 2023
@mudler mudler added refactoring Areas of code that needs refactoring, or have a technical debt lane/factory MVP labels Mar 6, 2023
@Itxaka
Copy link
Member

Itxaka commented Mar 17, 2023

But wait! There is more: #1167

@mudler mudler mentioned this issue Mar 30, 2023
29 tasks
@jimmykarily
Copy link
Contributor

We'll do this: #1210

@mudler
Copy link
Member Author

mudler commented May 15, 2023

@Itxaka @jimmykarily I think we can close this, right? or there is anything pending? maybe we just have to get rid of the elemental-cli references?

@jimmykarily
Copy link
Contributor

jimmykarily commented May 15, 2023

This issue describes the original idea. Since then, we decided to merge the lifecycle parts of elemental-cli to the kairos-agent and the building parts somewhere in the osbuilder (which hasn't happened yet). Also the kairos-agent still shells out to elemental-cli for some of the things it does. In other words, we need to:

I don't think this is the right issue to track this work, after all it describes an older idea, but I don't know which issue it the right one. Let's discuss this in tomorrow's planning an make sure we capture the remaining work.

@jimmykarily
Copy link
Contributor

Moved some work here: #1633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lane/factory MVP refactoring Areas of code that needs refactoring, or have a technical debt
Projects
Archived in project
Development

No branches or pull requests

3 participants