Fix release of framework image #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mauro Morales <[email protected]>
mauromorales
force-pushed
the
fix-multi-framework-image-on-relese
branch
from
734715b
to
76b6bcc
Compare
Signed-off-by: Mauro Morales <[email protected]>
Itxaka
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
silly me wanted to have a version check originally by using just regex and of course didn't think of all the issues that would happen with release candidates or other semver variations. With this change, the default is master, if the consumer passes "git" then the git version is used (useful for releases). If the consumer passes anything else, then that value is used as framework image (useful for development or other special cases)