Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming issue in rc3 #2065

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix naming issue in rc3 #2065

merged 1 commit into from
Dec 7, 2023

Conversation

mauromorales
Copy link
Member

@mauromorales mauromorales commented Dec 7, 2023 •
edited
Loading

⚠️ This is 1 of the 2 issues on the naming of rc3 that need to be addressed before we can cut a final release

Have naming.sh deal separately with base and other artifacts.

We should move to the versioneer asap since it is tested

@mauromorales mauromorales requested a review from a team December 7, 2023 16:55
@mauromorales mauromorales self-assigned this Dec 7, 2023
@mauromorales mauromorales merged commit 25c98b2 into master Dec 7, 2023
33 of 34 checks passed
@mauromorales mauromorales deleted the fix-missing-variant branch December 7, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Itxaka Itxaka Itxaka approved these changes

Assignees

@mauromorales mauromorales

Labels
None yet
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauromorales @Itxaka