Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Use framework images built on new repo #2074

Merged
merged 4 commits into from
Dec 13, 2023
Merged

✨ Use framework images built on new repo #2074

merged 4 commits into from
Dec 13, 2023

Conversation

mauromorales
Copy link
Member

Fixes #1975

@mauromorales mauromorales changed the title Use framework images built on new repo [WIP] Use framework images built on new repo Dec 11, 2023
@mauromorales mauromorales marked this pull request as draft December 11, 2023 20:43
@mauromorales mauromorales changed the title [WIP] Use framework images built on new repo ✨ Use framework images built on new repo Dec 12, 2023
@mauromorales mauromorales self-assigned this Dec 12, 2023
@mauromorales mauromorales marked this pull request as ready for review December 12, 2023 16:43
@mauromorales mauromorales requested a review from a team December 12, 2023 16:43
mauromorales
mauromorales commented Dec 12, 2023
View reviewed changes
images/Dockerfile.kairos-alpine
@@ -184,15 +188,6 @@ ARG MODEL
ARG REGISTRY_AND_ORG="quay.io/kairos"
ARG K3S_VERSION
ARG TARGETARCH
ARG OS_NAME=kairos-${VARIANT}-${FLAVOR}-${FLAVOR_RELEASE}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes were just because the files were not updated with the latest changes in the Dockerfile.kairos image. I will try to get back to the base images ticket to avoid having this issues

Itxaka
Itxaka approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I wonder if we should provide luet in the framework image if it's a dependency. After all we add all Kairos bits and bops by this so let feels like it should be bundled

jimmykarily
jimmykarily reviewed Dec 13, 2023
View reviewed changes
Earthfile Outdated Show resolved Hide resolved
@mauromorales
Use latest release by default
0cf79f5 
Signed-off-by: Mauro Morales <[email protected]>
@mauromorales
remove concept of security profile
e13bd16 
Generic images don't reflect it anymore so this can be considered part of the version

Signed-off-by: Mauro Morales <[email protected]>
@mauromorales mauromorales merged commit 3ee95d7 into master Dec 13, 2023
34 checks passed
@mauromorales mauromorales deleted the 1975-framework-image-new-repo branch December 13, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Itxaka Itxaka Itxaka approved these changes

@jimmykarily jimmykarily jimmykarily approved these changes

Assignees

@mauromorales mauromorales

Labels
None yet
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move framework images to their own repo
3 participants
@mauromorales @Itxaka @jimmykarily