Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Revert the trivy DB changes #2889

Merged
merged 1 commit into from
Oct 1, 2024
Merged

🤖 Revert the trivy DB changes #2889

merged 1 commit into from
Oct 1, 2024

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Sep 25, 2024

While locally it works as it caches the image witht he DB already on it, on CI it doesnt work and pulls the DB twice, so its the same as it was before.

While locally it works as it caches the image witht he DB already on it,
on CI it doesnt work and pulls the DB twice, so its the same as it was
before.

Signed-off-by: Itxaka <[email protected]>
@Itxaka Itxaka requested a review from a team September 25, 2024 08:22
@jimmykarily
Copy link
Contributor

Strange though, why? Do we declare defeat?

@Itxaka
Copy link
Member Author

Itxaka commented Sep 25, 2024

Strange though, why? Do we declare defeat?

I do. I have no idea why would that not work, but too many changes for nothing :(

I'll pick it down the line again when I got more time 😭

@Itxaka
Copy link
Member Author

Itxaka commented Sep 26, 2024

mmmh. Maybe we can do this separatedly instead.

  • build image or whatever
  • then scan with trivy the docker image generated, should be the same as scanning the fs inside the image

so the scan can just have a retry AND maybe we can just use the default trivy action from github which Im sure its leass problematic

and less code in earthly

@mauromorales
Copy link
Member

Would it make sense to try something like https://github.com/marketplace/actions/cache-trivy ?

@jimmykarily
Copy link
Contributor

Would it make sense to try something like https://github.com/marketplace/actions/cache-trivy ?

Moved to another ticket: #2904
Let's merge this revert and work on it on the new ticket.

@jimmykarily jimmykarily merged commit f55def8 into master Oct 1, 2024
42 of 43 checks passed
@jimmykarily jimmykarily deleted the revert_trivy branch October 1, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants