Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Build Ubuntu 24.04 Standard Image UKI on Github #2940

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

bencorrado
Copy link
Contributor

What this PR does / why we need it:
Until the standard packages can be auto installed as sysext I think this gives a way to work with standard UKI images. I can open a ticket on this for the future. This will help me to build with the released file sets and test changes more quickly.

Which issue(s) this PR fixes
Discussed at https://cloud-native.slack.com/archives/C0707M8UEU8/p1727801588480279?thread_ts=1727801588.480279&cid=C0707M8UEU8

I don't have a great way to set all of this without the full CI/CD access, so if someone has a few minutes to review before accepting that would be great.

I changed the logging filename to include the variant, so they do not overwrite. I could not find anything this affects, but I might not have full visibility.

I don't have a great way to set all of this without the full CI/CD access, so if someone has a few minutes to review before accepting that would be great.

I changed the logging filename to include the variant, so they do not overwrite.  I could not find anything this affects, but I might not have full visibility.

Until the standard packages can be auto installed as sysext I think this gives a way to work with standard UKI images.  I can open a ticket on this for the future.

Discussed here: https://cloud-native.slack.com/archives/C0707M8UEU8/p1727801588480279?thread_ts=1727801588.480279&cid=C0707M8UEU8

Signed-off-by: Ben Corrado <[email protected]>
@Itxaka
Copy link
Member

Itxaka commented Oct 15, 2024

I think @jimmykarily was also working on this?

@jimmykarily
Copy link
Contributor

I was just adding the standard artifact to the releases here: #2929
This PR is more about testing it. We should probably do both.

@Itxaka
Copy link
Member

Itxaka commented Oct 16, 2024

umm, I think this will never pass due Ben not having permissions to see the earthly token. Merging this directly, will fix it if we broke it somehow

@Itxaka Itxaka merged commit 1221749 into kairos-io:master Oct 16, 2024
28 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants